Skip to content

Commit

Permalink
fix grpc#4427
Browse files Browse the repository at this point in the history
  • Loading branch information
jtattermusch committed Mar 1, 2016
1 parent 2edea9c commit 7d91dc3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
10 changes: 0 additions & 10 deletions src/csharp/Grpc.Core/Internal/AsyncCallServer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -193,16 +193,6 @@ private void HandleFinishedServerside(bool success, bool cancelled)
lock (myLock)
{
finished = true;

if (cancelled)
{
// Once we cancel, we don't have to care that much
// about reads and writes.

// TODO(jtattermusch): is this still necessary?
Cancel();
}

ReleaseResourcesIfPossible();
}
// TODO(jtattermusch): handle error
Expand Down
2 changes: 0 additions & 2 deletions src/csharp/Grpc.IntegrationTesting/InteropClientServerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,12 @@ public async Task CustomMetadata()
}

[Test]
[Ignore("TODO: see #4427")]
public async Task StatusCodeAndMessage()
{
await InteropClient.RunStatusCodeAndMessageAsync(client);
}

[Test]
[Ignore("TODO: see #4427")]
public void UnimplementedMethod()
{
InteropClient.RunUnimplementedMethod(UnimplementedService.NewClient(channel));
Expand Down

0 comments on commit 7d91dc3

Please sign in to comment.