Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary workaround for copy issue #114

Closed
wants to merge 1 commit into from
Closed

temporary workaround for copy issue #114

wants to merge 1 commit into from

Conversation

mac2000
Copy link
Contributor

@mac2000 mac2000 commented May 30, 2020

fix for #113 it is kind of ugly but working in either case as you have mentioned editor itself probably should be part of src and have no separate package.json which will make things much easier in future

ps: also downgraded @types/express to match installed express version without it build is broken

in my fork github action is green hope after creating PR to see it green also

@mac2000 mac2000 closed this May 30, 2020
@IvanGoncharov
Copy link
Member

ps: also downgraded @types/express to match installed express version without it build is broken

@mac2000 I was bitten by this multiple times:
https://github.com/DefinitelyTyped/DefinitelyTyped#how-do-definitely-typed-package-versions-relate-to-versions-of-the-corresponding-library

The patch release number of the type declaration package (e.g. .0 in 10.12.0) is initialized to zero by Definitely Typed and is incremented each time a new @types/node package is published to NPM for the same major/minor version of the corresponding library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mac2000 @IvanGoncharov