Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Nav #744

Closed
wants to merge 10 commits into from
Closed

Potential Nav #744

wants to merge 10 commits into from

Conversation

idalithb
Copy link
Contributor

-potential left-side navigation structure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should setup a redirect for this page so old paths don't see 404

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I just realized that I approved #741 and it got merged without redirects. 🥲 @idalithb, are you able to add those, maybe all in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idalithb – I've done it in #753, if you want to take a look at the diff and the comments there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to resolve this, but a redirect still needs to be added for the Billing page, if we indeed want to move it (I left a comment about that here).

website/pages/en/_meta.js Outdated Show resolved Hide resolved
website/pages/en/_meta.js Outdated Show resolved Hide resolved
@idalithb idalithb requested a review from a team as a code owner August 30, 2024 20:37
Comment on lines 12 to +13
tokenomics: 'Tokenomics',
arbitrum: 'Scaling with Arbitrum',
contracts: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong, but I feel like Tokenomics should be under "The Graph Network". And maybe even Contracts?

type: 'heading',
title: 'Subgraphs',
title: 'Subgraph Developers',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution 👍

@@ -1,9 +1,9 @@
export default {
overview: 'Overview',
benefits: 'Benefits',
billing: '',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as to why Billing was moved to The Graph Network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants