Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to spark-version: 3.5.4 and fix Connected component suite #478

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Update to spark-version: 3.5.4 and fix Connected component suite #478

merged 3 commits into from
Jan 13, 2025
+134 −125

Conversation

bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Jan 12, 2025 •
edited
Loading

This pull request includes updates to the CI workflows and enhancements to the ConnectedComponents object in the ConnectedComponents.scala file. The most important changes are listed below:

CI Workflow Updates:

  • Updated the Spark version from 3.5.0 to 3.5.4 in the Python CI workflow file .github/workflows/python-ci.yml.
  • Updated the Spark version from 3.5.0 to 3.5.4 in the Scala CI workflow file .github/workflows/scala-ci.yml.

Enhancements to ConnectedComponents:

  • Added code to store the original Adaptive Query Execution (AQE) setting and disable AQE during the execution of the ConnectedComponents algorithm in ConnectedComponents.scala.
  • Ensured that the original AQE setting is restored after the execution of the ConnectedComponents algorithm in ConnectedComponents.scala.

@bjornjorgensen bjornjorgensen mentioned this pull request Jan 12, 2025
Closed
@bjornjorgensen bjornjorgensen changed the title Test120125 Update to spark-version: 3.5.4 Jan 12, 2025
@bjornjorgensen bjornjorgensen changed the title Update to spark-version: 3.5.4 Update to spark-version: 3.5.4 and fix Connected component suite Jan 12, 2025
@rjurney
Copy link
Collaborator

rjurney commented Jan 13, 2025

@bjornjorgensen The code looks great, thank you very much for this contribution! I hope you enjoyed it and can contribute more to GraphFrames :)

Testing it now... Okay, it passes two components and two dangling vertices instantly without issue... looking good!

[info] All tests passed.
[success] Total time: 68 s, completed Jan 13, 2025, 2:53:24 AM

In my own development, I am a little confused about where to find what settings can be changed at the time you create a SparkSession and once it exists. Approving now!

rjurney
rjurney approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@rjurney rjurney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@rjurney rjurney merged commit ef4c4c5 into graphframes:master Jan 13, 2025
3 checks passed
@bjornjorgensen bjornjorgensen deleted the test120125 branch January 13, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjurney rjurney rjurney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjornjorgensen @rjurney