Fix/4123 click panic #4174
Open
Fix/4123 click panic #4174
+35
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
requested review from
codebien,
olegbespalov and
inancgumus
and removed request for
a team
Looks like the wrong frame was used. We retrieved the frame with h.ownerFrame, but then never used the value that was returned if it wasn't nil.
ankur22
force-pushed
the
fix/4123-click-panic
branch
from
e65d30f to
7fbcd21
Compare
olegbespalov
previously approved these changes
Jan 14, 2025
Being a bit more defensive against unexpected NPDs further along down the line of execution.
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
ankur22
force-pushed
the
fix/4123-click-panic
branch
from
5a8f184 to
eb16372
Compare
olegbespalov
approved these changes
Jan 14, 2025
codebien
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This makes changes to the codebase so that we alert the user of an error that they could work with to try and fix their environment.
Why?
When either the load generator and/or chrome are under heavy load (CPU is nearly maxed out), a user might sometimes see an NPD error. This isn't useful and the user cannot do anything with that information. We protect against an NPD by returning an error which should give the user some idea of what steps to take to get their test to work (increase compute resources).
More details can be found in #4124 (comment).
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#4124