Dashboards: Change the way dashboard not found error is handled #98950
+662
−365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
requested review from
torkelo,
axelavargas,
ivanortegaalba and
harisrozajac
|
@dprokop nice! I remember spending half a day or something on thing a few months ago, gave up when fixing all the tests looked to take me another day or so, hope you have better luck because this is a really good change! |
dprokop
requested review from
juanicabanas,
AgnesToulet,
joshhunt and
aocenas
and removed request for
a team
dprokop
added
no-backport
Sergej-Vlasov
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGTM! 👍
TODO - Remove left behind comments
Tested with various cases:
- load non-existent dashboard/snapshot
- navigate to non-existent dashboard
- adjust dashboard/panel share link to non-existent dashboard
- use dashboard link to navigate to non-existent dashboard
Could not test:
- embeded dashboard/panel
Issues encountered:
- when you navigate to non-existent panel via dashboard/panel link the top actions bar remains
- probably not related to this but lacks clean up from scenes dashboard
Screen.Recording.2025-01-15.at.16.50.38.mov
|
/deploy-to-hg |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way how dashboard/public dash/snapshots/solo view 404 issue is handled. Before this PR, such a view would be rendered as a "regular" dashboard, would require fake 404 dashboard modelcreation etc. With this PR:
DashboardScenePageStateManagerand rendered accordinglydashboardNotFoundmetadata is removedAnnoKeyDashboardNotFoundk8s client annotation is removedTODO: