Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableNG: Column re-size handler #98901

Merged
merged 3 commits into from
Jan 16, 2025
Merged

TableNG: Column re-size handler #98901

merged 3 commits into from
Jan 16, 2025

Conversation

Develer
Copy link
Contributor

@Develer Develer commented Jan 13, 2025

What is this feature?

This PR cover feature parity for column resizing.

Which issue(s) does this PR fix?:

Fixes #94778

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Develer Develer added area/panel/table no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel labels Jan 13, 2025
@Develer Develer added this to the 12.0.x milestone Jan 13, 2025
@Develer Develer self-assigned this Jan 13, 2025
@Develer Develer marked this pull request as ready for review January 14, 2025 14:24
@Develer Develer requested review from grafanabot and a team as code owners January 14, 2025 14:24
@Develer Develer requested review from leeoniya, drew08t and adela-almasan and removed request for a team January 14, 2025 14:24
drew08t
drew08t approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@drew08t drew08t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with merging this as is as a good step forward!

A couple things to follow up on:

  1. In TableOG, clicking on the resize control seems to make columns expand to any open space. Similar behavior to double clicking in Excel or Google Sheets, except in that case, it collapses to the minimum possible width. Probably something we can explore further in Phase 3 as a UX enhancement.
    Jan-15-2025 22-45-33

  2. In TableOG, field override is able to collapse width to less than the global minimum width. In this case, we should probably address this in Phase 2 as some existing tables might take advantage of this behavior and be impacted by constraining overrides by minimum width. Please create a follow-up in Phase 2.

@Develer
Copy link
Contributor Author

Develer commented Jan 16, 2025 •
edited
Loading

@drew08t thank you for reviewing, just add a follow-up tasks to the epic:

@Develer Develer merged commit 6d83c2c into table-ng Jan 16, 2025
6 of 7 checks passed
@Develer Develer deleted the 94778-header-resize branch January 16, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew08t drew08t drew08t approved these changes

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@leeoniya leeoniya Awaiting requested review from leeoniya leeoniya is a code owner automatically assigned from grafana/dataviz-squad

@adela-almasan adela-almasan Awaiting requested review from adela-almasan adela-almasan is a code owner automatically assigned from grafana/dataviz-squad

Assignees

@Develer Develer

Labels
area/dataviz Anything that relates to Data Visualisation work but is not specific to one panel area/frontend area/panel/table no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@Develer @drew08t