Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Support query by deprecatedInternalID #98344

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Dec 22, 2024

WIP/not yet working 😢

@ryantxu ryantxu added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Dec 22, 2024
@@ -343,6 +356,14 @@ func StandardSearchFields() SearchableDocumentFields {
Type: ResourceTableColumnDefinition_INT64,
Description: "created timestamp", // date?
},
{
Name: SEARCH_FIELD_DEPRECATED_INTERNAL_ID,
Type: ResourceTableColumnDefinition_STRING, // NUMBER!!!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^ not yet working, so trying as a string -- better as a number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant