feat(common/loki): switch Snappy compression from golang/snappy
to klauspost/compress/snappy
for better compression
#955
+14
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I discovered that Snappy compression could be done from
github.com/klauspost/compress/snappy
. It's advertised as having "better compression" so I think the switch could be a performance win.In addition, there's still usage of old
Shopify/sarama
, which isIBM/sarama
now.Hijack this PR are also replacements of
golang.org/x/exp/maps
andgolang.org/x/exp/slices
to stdlib's equivalences.Which issue(s) this PR fixes
N/A
Notes to the Reviewer
PR Checklist