Skip to content

support endpointslices.discovery.k8s.io for prometheus.operator.servicemonitorsΒ #1714

Closed
@GroovyCarrot

Description

Request

The prometheus.operator.servicemonitors component currently only supports the legacy endpoints discovery resource.

Recently support was added to the prometheus operator for the new endpointslices.discovery.k8s.io resources: prometheus-operator/prometheus-operator#6672

Following the pattern they implemented, would suggest we need a role = "endpoints|endpointslices" argument on the component to decide which resource to use for discovery, as they did not opt for a field on the CRD to denote the role.

endpointslices are already supported by discovery.kubernetes.

Use case

This is important as endpointslices are far more flexible, supporting FQDNs as well as IP addresses, and offers tenants a way to define static_configs / discovery.relabel targets via a resource in kubernetes rather than in the agent config itself.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions