-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade x/tools and gopls to 1c30660f #911
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
myitcv
changed the title
[WIP] deps: update x/tools and gopls to 6123e77877b2
[WIP] deps: upgrade x/tools and gopls to df70183b
Jul 29, 2020
|
myitcv
added
gopls
gopls related issue
onhold
Probably pending some 3rd party issue
labels
Jul 29, 2020
* gopls/integration/govim: enable running at main 1c30660f * internal/lsp: fix a few staticcheck suggestions, some cleanup 6b78e25f * internal/lsp: don't show diagnostic in go.mod for direct dependencies 8afe7e08 * internal/lsp: properly check for nil on i.enclosing 449c5851 * internal/lsp/source: move initial extract function logic to lsp/command 1c1ec420 * internal/lsp/source: add extra nil check in searchForEnclosing df70183b * internal/lsp: fix logged message for gc_details e8769ccb * internal/lsp: remove uses of crypto/sha1 in gopls 0dd562f3 * internal/lsp: show compiler optimization decisions 95780ea8 * internal/lsp: de-duplicate logic for canExtractVariable edd3c8e9 * internal/lsp: check URIs of all workspace folders 342ee105 * internal/lsp/source: add a unit test for searchForEnclosing e7a7e3a8 * internal/lsp: remove PackageHandle b6476686 * internal/lsp: replace ParseGoHandle with concrete data a9439ae9 * internal/lsp/cache: fix parseKey 4d1d9acc * internal/lsp: pass snapshot/view to memoize.Functions 72051f79 * internal/lsp/cache: remove files from the memoize.Store 60da08ac * internal/lsp: minimize PackageHandle interface 051e64e6 * internal/lsp: handle bad formatting with CRLF line endings 2ad651e9 * internal/lsp: support return statements in extract function 3c048e20 * internal/lsp: update code for LSP protocol cd83430b * internal/lsp: allow narrower scope for convenience CodeActions 55644ead * internal/lsp: correctly marshal arguments for upgrade code lens 7b4c4ad3 * internal/lsp: correctly invalidate metadata for batched changes 59c6fc0b * internal/lsp: support refactor.extract through commands 92670837 * internal/lsp: fix hover link for embedded fields and methods eaaaedc6 * internal/lsp: fix GlobPattern for watching files 102e7d35 * internal/lsp: add parse errors as diagnostics even when parsing fails b5fc9d35 * internal/lsp: fix hover for implicit type switch variable declarations 7017fd6b * internal/lsp: add errors for missing modules that don't map to an import cbb3c69a * internal/lsp: move undeclaredname suggested fix out of analysis 37a045f3 * internal/lsp/regtest: fix WithoutWorkspaceFolders option 0e1f6f5c * internal/lsp/regtest: add a simple stress test 93b64502 * internal/lsp/regtest: add run options to support stress testing 84d0e3d1 * internal/lsp/fake: move to a struct for configuring the sandbox a5e28d8d * internal/lsp: lift env out of the sandbox into the editor 1ff154e6 * internal/lsp: show errors in indirect dependencies as diagnostics d2c1b4b2 * internal/lsp: treat the module root as the workspace root, if available 0cdb17d1 * internal/lsp/cache: copy *packages.Config environment completely b3d141dd * internal/lsp: don't publish duplicate diagnostics in one report 80cb7970 * go/packages: add failing test for golang/go#37098 188b3828 * go/packages: find filenames in error strings if not in position a7c6fd06 * internal/lsp: separate test and benchmark codelens bd1e9de8 * go/analysis/passes/unmarshal: Add check for asn1.Unmarshal 70419130 * internal/lsp: support `go mod tidy` on save without diagnostics 6123e778 * internal/lsp: try to parse diagnostics out of `go list` errors b42efcd1 * internal/lsp: handle unknown revision in go.mod file 0a5cd101 * internal/lsp: handle on-disk file deletions for opened files acdb8c15 * internal/lsp: change the way that we pass arguments to command 5ea36318 * internal/lsp: return the actual range from convenience code actions b8e13e1a
myitcv
changed the title
[WIP] deps: upgrade x/tools and gopls to df70183b
deps: upgrade x/tools and gopls to 1c30660f
Jul 29, 2020
leitzler
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.