fix(translate-v2): Ensure access token is fetched with recent googlea…

…uth versions in the non-api-key case (#28096)
googleapis · Dec 11, 2024 · 398f03d · 398f03d
1 parent 5494628
commit 398f03d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/google-cloud-translate-v2/lib/google/cloud/translate/v2/service.rb b/google-cloud-translate-v2/lib/google/cloud/translate/v2/service.rb
@@ -140,7 +140,7 @@ def sign_http_request! request
             client = credentials.client
             return if client.nil?
 
-            client.fetch_access_token! if client.expires_within? 30
+            client.fetch_access_token! if client.access_token.nil? || client.expires_within?(30)
             client.generate_authenticated_request request: request
             request
           end

diff --git a/google-cloud-translate-v2/test/google/cloud/translate/v2/service_test.rb b/google-cloud-translate-v2/test/google/cloud/translate/v2/service_test.rb
@@ -20,6 +20,10 @@ def expires_within? _
     false
   end
 
+  def access_token
+    :token
+  end
+
   def generate_authenticated_request request:
   end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -20,6 +20,10 @@ def expires_within? _ @@
         false
       end
+      def access_token
+        :token
+      end
       def generate_authenticated_request request:
       end
     end
@@ Expand Down @@