Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split log_wrapper_helpers.h #10404

Merged
merged 1 commit into from
Dec 8, 2022
Merged

refactor: split log_wrapper_helpers.h #10404

merged 1 commit into from
Dec 8, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 8, 2022 •
edited
Loading

I will need some of these functions in libraries that do not depend on google_cloud_cpp_grpc_utils. I also improved the tests by a tiny amount.

Part of the work for #10136

This change is Reviewable

@coryan
refactor: split log_wrapper_helpers.h
f2be493 
I will need some of these functions in libraries that do not depend on
`google_cloud_cpp_grpc_utils`.  I also improved the tests by a tiny
amount.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f2be493500e14befff93c88d143bb689ef969fa8

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 8, 2022 •
edited
Loading

Codecov Report

Base: 93.84% // Head: 93.85% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f2be493) compared to base (4dbafbc).
Patch coverage: 83.52% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10404   +/-   ##
=======================================
  Coverage   93.84%   93.85%           
=======================================
  Files        1601     1607    +6     
  Lines      145676   145688   +12     
=======================================
+ Hits       136714   136735   +21     
+ Misses       8962     8953    -9
Impacted Files Coverage Δ
google/cloud/internal/debug_string_protobuf.cc 100.00% <ø> (ø)
...oogle/cloud/internal/debug_string_protobuf_test.cc 97.43% <ø> (ø)
google/cloud/internal/log_wrapper.h 93.68% <ø> (ø)
google/cloud/internal/debug_string_status.cc 66.66% <66.66%> (ø)
google/cloud/internal/debug_future_status.cc 100.00% <100.00%> (ø)
google/cloud/internal/debug_future_status_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/debug_string.cc 100.00% <100.00%> (ø)
google/cloud/internal/debug_string_status_test.cc 100.00% <100.00%> (ø)
google/cloud/internal/debug_string_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review December 8, 2022 20:41
@coryan coryan requested a review from a team as a code owner December 8, 2022 20:41
@coryan coryan enabled auto-merge (squash) December 8, 2022 20:43
@coryan coryan merged commit 7036edb into googleapis:main Dec 8, 2022
@coryan coryan deleted the refactor-split-log-wrapper-helpers branch December 8, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coryan @google-cloud-cpp-bot @devbww