Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/#8176 - Add REST and datastore APIs for audience settings #8407

Merged
merged 27 commits into from
Mar 21, 2024
Merged

Enhance/#8176 - Add REST and datastore APIs for audience settings #8407

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8a9459f
Add fetchGetAudienceSettingsStore.
hussain-t Mar 14, 2024
84db1e6
Add getAudienceSettings resolver.
hussain-t Mar 14, 2024
886a573
Add getAudienceSettings reducer.
hussain-t Mar 14, 2024
e324ce4
Add fetchSaveAudienceSettingsStore.
hussain-t Mar 14, 2024
3631d22
Add saveAudienceSettings action.
hussain-t Mar 14, 2024
5bfdaf4
Add audienceSettings partial store.
hussain-t Mar 14, 2024
ce2eba0
Add get and post audience-settings datapoints.
hussain-t Mar 14, 2024
f33605c
Add Audience_Settings class.
hussain-t Mar 14, 2024
68408f5
Fix PHP lint.
hussain-t Mar 14, 2024
e48fba6
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
hussain-t Mar 14, 2024
23394ba
Return state.audienceSettings?.settings in getAudienceSettings.
hussain-t Mar 14, 2024
572f32a
Add getConfiguredAudiences selector.
hussain-t Mar 14, 2024
4bc20fe
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
hussain-t Mar 15, 2024
d167b29
Add isAudienceSegmentationWidgetHidden selector.
hussain-t Mar 15, 2024
943e2e7
Add haveConfiguredAudiencesChanged selector.
hussain-t Mar 15, 2024
89212da
Add setConfiguredAudiences action.
hussain-t Mar 15, 2024
bc42327
Add setAudienceSegmentationWidgetHidden action.
hussain-t Mar 15, 2024
d5e0325
Add Audience_SettingsTest.
hussain-t Mar 17, 2024
d3de1de
Update haveConfiguredAudiencesChanged selector.
hussain-t Mar 18, 2024
a216b1b
Add audience settings store actions tests.
hussain-t Mar 18, 2024
86db359
Add audience settings selectors tests.
hussain-t Mar 18, 2024
3a89802
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
hussain-t Mar 18, 2024
0acfada
Address comments.
hussain-t Mar 19, 2024
97ca77d
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
hussain-t Mar 19, 2024
e5c381f
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
hussain-t Mar 20, 2024
72149e8
Add Invalid_Param_Exception class.
hussain-t Mar 20, 2024
d7e4d0b
Improvements and address feedback.
hussain-t Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return state.audienceSettings?.settings in getAudienceSettings.
  • Loading branch information
@hussain-t
hussain-t committed Mar 14, 2024
commit 23394bad280549d8529c5b1795c58c4945c1beb5
2 changes: 1 addition & 1 deletion assets/js/modules/analytics-4/datastore/audience-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const baseSelectors = {
* @return {(Object|undefined)} Audience settings; `undefined` if not loaded.
*/
getAudienceSettings( state ) {
return state.audienceSettings;
return state.audienceSettings?.settings;
},
};

Expand Down