Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/#8176 - Add REST and datastore APIs for audience settings #8407

Merged
merged 27 commits into from
Mar 21, 2024
Merged

Enhance/#8176 - Add REST and datastore APIs for audience settings #8407

merged 27 commits into from
Mar 21, 2024

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Mar 18, 2024 •
edited by kuasha420
Loading

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

hussain-t added 22 commits March 14, 2024 16:50
@hussain-t
Add fetchGetAudienceSettingsStore.
8a9459f
@hussain-t
Add getAudienceSettings resolver.
84db1e6
@hussain-t
Add getAudienceSettings reducer.
886a573
@hussain-t
Add fetchSaveAudienceSettingsStore.
e324ce4
@hussain-t
Add saveAudienceSettings action.
3631d22
@hussain-t
Add audienceSettings partial store.
5bfdaf4
@hussain-t
Add get and post audience-settings datapoints.
ce2eba0
@hussain-t
Add Audience_Settings class.
f33605c
@hussain-t
Fix PHP lint.
68408f5
@hussain-t
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
e48fba6
@hussain-t
Return state.audienceSettings?.settings in getAudienceSettings.
23394ba
@hussain-t
Add getConfiguredAudiences selector.
572f32a
@hussain-t
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
4bc20fe
@hussain-t
Add isAudienceSegmentationWidgetHidden selector.
d167b29
@hussain-t
Add haveConfiguredAudiencesChanged selector.
943e2e7
@hussain-t
Add setConfiguredAudiences action.
89212da
@hussain-t
Add setAudienceSegmentationWidgetHidden action.
bc42327
@hussain-t
Add Audience_SettingsTest.
d5e0325
@hussain-t
Update haveConfiguredAudiencesChanged selector.
d3de1de
@hussain-t
Add audience settings store actions tests.
a216b1b
@hussain-t
Add audience settings selectors tests.
86db359
@hussain-t
Merge branch 'develop' into enhance/#8176-rest-ds-for-audience-settings.
3a89802
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2024 •
edited
Loading

Build files for d7e4d0b have been deleted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2024 •
edited
Loading

Size Change: +589 B (0%)

Total Size: 1.4 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 23.7 kB -1 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 56.9 kB -1 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.1 kB -2 B (0%)
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.1 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 18.3 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 24.4 kB -1 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 65 kB +6 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 89.9 kB +2 B (0%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 15.4 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 110 kB +7 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 109 kB +709 B (+1%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB -7 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 57.6 kB -2 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 29.8 kB +15 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 58.7 kB -2 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 46.5 kB -3 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 316 kB -1 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 33.1 kB -132 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 59.4 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 52.3 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 929 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 778 B
./dist/assets/js/googlesitekit-api-********************.js 10 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.86 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-modules-********************.js 21.7 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/googlesitekit-splash-********************.js 71.7 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

zutigrm
zutigrm requested changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@zutigrm zutigrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hussain-t, looks good, I just left few minor comments.

zutigrm
zutigrm approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@zutigrm zutigrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hussain-t LGTM

kuasha420
kuasha420 suggested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@kuasha420 kuasha420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hussain-t ! This is nearly there. I've left a few comment for you to consider. Please, have a look.

assets/js/modules/analytics-4/datastore/audience-settings.js Outdated Show resolved Hide resolved
assets/js/modules/analytics-4/datastore/audience-settings.js Outdated Show resolved Hide resolved
includes/Modules/Analytics_4.php Outdated Show resolved Hide resolved
includes/Modules/Analytics_4.php Outdated Show resolved Hide resolved
includes/Modules/Analytics_4.php Outdated Show resolved Hide resolved
includes/Modules/Analytics_4.php Outdated Show resolved Hide resolved
kuasha420
kuasha420 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@kuasha420 kuasha420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hussain-t! LGTM 🎉

@kuasha420 kuasha420 merged commit 029b761 into develop Mar 21, 2024
29 checks passed
@kuasha420 kuasha420 deleted the enhance/#8176-rest-ds-for-audience-settings branch March 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zutigrm zutigrm zutigrm approved these changes

@kuasha420 kuasha420 kuasha420 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hussain-t @kuasha420 @zutigrm