Intentional bug for verifying ASAN #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought you would verify this locally. checking in to clusterfuzz will cause this to break regression ranges for future crashes, just fyi. devs getting confused is not good :( |
jonathanmetzman
added a commit
that referenced
this pull request
Jul 31, 2018
This reverts commit e6673ea.
jonathanmetzman
added a commit
that referenced
this pull request
Jul 31, 2018
tmatth
pushed a commit
to tmatth/oss-fuzz
that referenced
this pull request
Oct 22, 2018
* Remove some checks that have landed in Skia proper * intentional breackage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be landed after #1677 and then reverted after verifying ASAN correctly finds and files a bug.