Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little refactorings for cleaner code #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Little refactorings for cleaner code #9

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1bca45a
fix: remove extra parenthesis in readme
uburuntu Feb 22, 2021
bbb97ad
fix: 'abc.abstractproperty' is deprecated since Python 3.3
uburuntu Feb 22, 2021
ac865dc
ref: function call can be replaced with set literal
uburuntu Feb 22, 2021
76c7c41
ref: remove not used local variables
uburuntu Feb 22, 2021
345a8b9
ref: instance attribute defined outside __init__
uburuntu Feb 22, 2021
183d961
ref: remove redundant parentheses
uburuntu Feb 22, 2021
c1e6c3a
ref: dont shadow built-in
uburuntu Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ref: dont shadow built-in
  • Loading branch information
@uburuntu
uburuntu committed Feb 22, 2021
commit c1e6c3a40bd077b657cabd65c9620b8d5a214506
2 changes: 1 addition & 1 deletion model_search/controller_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _create_spec(replay_towers=0, ensemble_type="none"):
return output


_TRIALS = [trial_module.Trial({"id": id + 1}) for id in range(105)]
_TRIALS = [trial_module.Trial({"id": id_ + 1}) for id_ in range(105)]


def _create_trials(num_trials):
Expand Down