Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Better docs for jax.numpy: minimum and maximum #23469

Merged
merged 1 commit into from
Sep 9, 2024
Merged

DOC: Better docs for jax.numpy: minimum and maximum #23469

merged 1 commit into from
Sep 9, 2024

Conversation

rajasekharporeddy
Copy link
Contributor

@rajasekharporeddy rajasekharporeddy commented Sep 6, 2024 •
edited
Loading

@dfm dfm self-assigned this Sep 8, 2024
dfm
dfm reviewed Sep 8, 2024
View reviewed changes
Copy link
Member

@dfm dfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There a small issue with the examples, but otherwise this looks good to me.

jax/_src/numpy/ufuncs.py

Inputs having ``nan``:

>>> x2 = jnp.array([nan, -3, 9])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like nan is undefined here!

Copy link
Contributor Author

@rajasekharporeddy rajasekharporeddy Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! nan is defined now.

dfm
dfm approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@dfm dfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Sep 9, 2024
@copybara-service copybara-service bot merged commit f069aeb into google:main Sep 9, 2024
16 checks passed
@rajasekharporeddy rajasekharporeddy deleted the testbranch1 branch September 9, 2024 14:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfm dfm dfm approved these changes

Assignees

@dfm dfm

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajasekharporeddy @dfm @kokoro-team