Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JsonWriter / JsonTreeWriter handling of invalid JSON structure #1763

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve JsonWriter / JsonTreeWriter handling of invalid JSON structure #1763

wants to merge 3 commits into from

Conversation

Marcono1234
Copy link
Collaborator

  • Adds exception messages to IllegalStateExceptions thrown by JsonTreeWriter
  • Fix JsonWriter not detecting invalid name (as top level or as array element) immediately

@Marcono1234
Add exception messages and tests for invalid JsonTreeWriter structure
01e0652
@Marcono1234
Fix JsonWriter not detecting invalid name immediately; improve tests
44e3efb 
Previously JsonWriter did not fail immediately when trying to write a name
in an empty document or an array. Instead it would only fail once a
corresponding value was written. Now it fails immediately.
@Marcono1234
Add test for closing JsonWriter with incomplete JSON
0f40144
@google-cla google-cla bot added the cla: yes label Aug 24, 2020
@Marcono1234 Marcono1234 mentioned this pull request Aug 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Marcono1234