Fix ambiguity of a type deduction in TEST_EQ macro for enum class
args.
#5630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR this code (in the
test.cpp
) was impossible:Due to ambiguity of type deduction, this code caused a compilation error like this:
This is a well-known problem (C++ DR1601):
However, all modern compilers break the rule C++17 16.4.2 introduced by DR 1601:
This PR adds a workaround and allows the use of simple checking of
enum class
values in tests:TEST_EQ(MyGame::Example::TestEnum::A, MyGame::Example::TestEnum::B);