Bitcoin SPV relayer: Relays blocks from Bitcoin to Native #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
| - name: Install dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libzmq3-dev pkg-config |
There was a problem hiding this comment.
is there a pure go version of zmq?
There was a problem hiding this comment.
Found https://github.com/go-zeromq/zmq4
NOt sure if it'll be compatible.
There was a problem hiding this comment.
Please test and let's see.
| // Copyright (c) 2022-2022 The Babylon developers | ||
| // Copyright (c) 2013-2016 The btcsuite developers | ||
| // Use of this source code is governed by an ISC | ||
| // license that can be found in the LICENSE file. |
There was a problem hiding this comment.
please note which parts of the files in this PR are not copied.
There was a problem hiding this comment.
Shall I put comments above the non-copied parts?
There was a problem hiding this comment.
Put comments in the code , or indicate in the review (clicking in this PR "add comment")
Co-authored-by: Robert Zaremba <robert@zaremba.ch> Signed-off-by: Udit Gulati <85029005+udit-gulati@users.noreply.github.com>
…tclient Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
… proof of each txn and submitting it to the lightclient Signed-off-by: udit-gulati <uditgulati6@gmail.com>
|
As noted last week, we need to add comments in the PR to the code that is "ours" to see what code is copied . |
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
…rge extract and submit transaction into one function Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Signed-off-by: udit-gulati <uditgulati6@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bitcoin -> Native blocks relayer
This new PR created because previous one #34 got messed up after multiple rebase from
masterbranch.Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.md