Skip to content

Commit

Permalink
net/url: fail TestParseErrors test when getting an unwanted error
Browse files Browse the repository at this point in the history
The TestParseErrors test function was not strict with unwanted errors
received from url.Parse(). It was not failing in such cases, now it does.

Change-Id: I18a26a68c1136f5c762989a76e04b47e33dd35f1
GitHub-Last-Rev: c33f984
GitHub-Pull-Request: #32954
Reviewed-on: https://go-review.googlesource.com/c/go/+/185080
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
  • Loading branch information
stefanb authored and odeke-em committed Aug 27, 2019
1 parent b963149 commit 32b9e56
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/net/url/url_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1456,7 +1456,7 @@ func TestParseErrors(t *testing.T) {
continue
}
if err != nil {
t.Logf("Parse(%q) = %v; want no error", tt.in, err)
t.Errorf("Parse(%q) = %v; want no error", tt.in, err)
}
}
}
Expand Down

0 comments on commit 32b9e56

Please sign in to comment.