Skip to content

Commit

Permalink
net/url: clarify QueryUnescape and PathUnescape doc
Browse files Browse the repository at this point in the history
In the doc for QueryUnescape and PathUnescape, clarify that by 0xAB we
means a substring with any two valid hexadecimal digits.

Fixes #18642

Change-Id: Ib65b130995ae5fcf07e25ee0fcc41fad520c5662
Reviewed-on: https://go-review.googlesource.com/77050
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
  • Loading branch information
ALTree authored and bradfitz committed Nov 14, 2017
1 parent fa1f52c commit 0d9dc04
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions src/net/url/url.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,18 +163,23 @@ func shouldEscape(c byte, mode encoding) bool {
return true
}

// QueryUnescape does the inverse transformation of QueryEscape, converting
// %AB into the byte 0xAB and '+' into ' ' (space). It returns an error if
// any % is not followed by two hexadecimal digits.
// QueryUnescape does the inverse transformation of QueryEscape,
// converting 3-byte encoded substrings of the form "%AB" into the
// hex-decoded byte 0xAB. It also converts '+' into ' ' (space).
// It returns an error if any % is not followed by two hexadecimal
// digits.
func QueryUnescape(s string) (string, error) {
return unescape(s, encodeQueryComponent)
}

// PathUnescape does the inverse transformation of PathEscape, converting
// %AB into the byte 0xAB. It returns an error if any % is not followed by
// two hexadecimal digits.
// PathUnescape does the inverse transformation of PathEscape,
// converting 3-byte encoded substrings of the form "%AB" into the
// hex-decoded byte 0xAB. It also converts '+' into ' ' (space).
// It returns an error if any % is not followed by two hexadecimal
// digits.
//
// PathUnescape is identical to QueryUnescape except that it does not unescape '+' to ' ' (space).
// PathUnescape is identical to QueryUnescape except that it does not
// unescape '+' to ' ' (space).
func PathUnescape(s string) (string, error) {
return unescape(s, encodePathSegment)
}
Expand Down

0 comments on commit 0d9dc04

Please sign in to comment.