Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

Honestly, I'm not sure that the problem is merely linegap. Using the original Height value, my lines were overwriting one another, which can't be explained by line_gap_ alone:

With this change, they are spaced correctly:

What's the name of that font file with a non-zero line gap. I went for a quick search for one earlier, but didn't find one easily.

Still, I'm not sure that replacing (a.scale) with (ascent + descent + lineGap) is the right thing for calculating Height. I suspect that the latter is slightly too small for most fonts, where the lineGap is zero and the glyphs don't go all the way to the edge of the em square...

The font in the image is roboto. But I think I was too quick to blame line
gap. As I mentioned, if the problem is just line gap, there shouldn't be
overlap between lines without it. Using scale, the lines overlap one
another.

On Fri, Apr 15, 2016, 03:12 Nigel Tao notifications@github.com wrote:

What's the name of that font file with a non-zero line gap. I went for a
quick search for one earlier, but didn't find one easily.

Still, I'm not sure that replacing (a.scale) with (ascent + descent +
lineGap) is the right thing for calculating Height. I suspect that the
latter is slightly too small for most fonts, where the lineGap is zero and
the glyphs don't go all the way to the edge of the em square...

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#32 (comment)

I was surprised that you consider ascent+descent+linegap to be the wrong way to compute line height, so I did a bit of searching. According to this page from the apple developers guide, it is the correct approach:

The total amount of ascent plus descent plus leading provides a font’s line height.

I don't think we should worry about linegap=0 causing colliding lines. According to the truetype reference manual the ascent and descent values from the hhea table are just artistic intent anyway:

The values for ascent, descent and lineGap represent the design intentions of the font's creator rather than any computed value, and individual glyphs may well exceed the the limits they represent.

I interpret these two facts to mean that, if a font has linegap=0, the creator either accounted for it in the ascent+descent, or they intend some lines to touch.

I don't have time to play around with this much more. If you'd prefer, I can close this PR (at best it's name is misleading, if not wrong), and open an issue instead. I can include the images from above and a reference to the font I used. It was Roboto-Regular.ttf, from here https://www.google.com/fonts/specimen/Roboto.

@eaburns I can play with it.