-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make swagger download automatically select architecture #19780
base: main
Are you sure you want to change the base?
Conversation
This does not work for all architectures, but at least amd64 and arm64. I could also add a switch statement, but ARM64 seems to be the most important arch to implement right now (goharbor#3505). Signed-off-by: Aaron Dewes <aaron.dewes@protonmail.com>
this command |
Could you please contribute in the following repo to support Harbor in ARM: Thanks |
The container is always a Linux container, isn't it? And https://github.com/goharbor/harbor-arm seems unmaintained. In my opinion, a second repo for arm is unnecessary considering how small the changes for arm64 support would need to be (This PR + another 10 line patch). So please reopen or reconsider this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19780 +/- ##
==========================================
- Coverage 67.56% 66.43% -1.14%
==========================================
Files 991 1048 +57
Lines 109181 116119 +6938
Branches 2719 2845 +126
==========================================
+ Hits 73768 77142 +3374
- Misses 31449 34595 +3146
- Partials 3964 4382 +418
Flags with carried forward coverage won't be shown. Click here to find out more. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
@Vad1mo Any news on this? |
It is not intended to work on Mac, the command is executed in the container and guaranteed to be there. The only thing it does is selection the right CPU architecture. which in terms allows you to build images on your ARM pc/mac I think it solves a problem and does not impact the current image build in any way. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Comprehensive Summary of your change
This does not work for all architectures, but at least amd64 and arm64. I could also add a switch statement, but ARM64 seems to be the most important arch to implement right now (#3505).
Issue being fixed
Helps towards #3505
Please indicate you've done the following: