Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make swagger download automatically select architecture #19780

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AaronDewes
Copy link

@AaronDewes AaronDewes commented Jan 1, 2024

Comprehensive Summary of your change

This does not work for all architectures, but at least amd64 and arm64. I could also add a switch statement, but ARM64 seems to be the most important arch to implement right now (#3505).

Issue being fixed

Helps towards #3505

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

This does not work for all architectures, but at least amd64 and arm64. I could also add a switch statement, but ARM64 seems to be the most important arch to implement right now (goharbor#3505).

Signed-off-by: Aaron Dewes <aaron.dewes@protonmail.com>
@AaronDewes AaronDewes requested a review from a team as a code owner January 1, 2024 21:30
@zyyw
Copy link
Contributor

zyyw commented Jan 2, 2024

this command dpkg --print-architecture doesn't work in MacOSX

@zyyw
Copy link
Contributor

zyyw commented Jan 2, 2024

Could you please contribute in the following repo to support Harbor in ARM:

Thanks

@zyyw zyyw closed this Jan 2, 2024
@AaronDewes
Copy link
Author

this command dpkg --print-architecture doesn't work in MacOSX

The container is always a Linux container, isn't it?

And https://github.com/goharbor/harbor-arm seems unmaintained.

In my opinion, a second repo for arm is unnecessary considering how small the changes for arm64 support would need to be (This PR + another 10 line patch).

So please reopen or reconsider this PR.

@Vad1mo Vad1mo reopened this Jan 12, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) January 12, 2024 10:11
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.43%. Comparing base (b7b8847) to head (98ff607).
Report is 343 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19780      +/-   ##
==========================================
- Coverage   67.56%   66.43%   -1.14%     
==========================================
  Files         991     1048      +57     
  Lines      109181   116119    +6938     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    77142    +3374     
- Misses      31449    34595    +3146     
- Partials     3964     4382     +418     
Flag Coverage Δ
unittests 66.43% <ø> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 597 files with indirect coverage changes

@Vad1mo Vad1mo added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jan 17, 2024
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Mar 19, 2024
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label May 19, 2024
@AaronDewes
Copy link
Author

@Vad1mo Any news on this?

@github-actions github-actions bot removed the Stale label May 20, 2024
@Vad1mo
Copy link
Member

Vad1mo commented May 28, 2024

this command dpkg --print-architecture doesn't work in MacOSX

It is not intended to work on Mac, the command is executed in the container and guaranteed to be there. The only thing it does is selection the right CPU architecture. which in terms allows you to build images on your ARM pc/mac

I think it solves a problem and does not impact the current image build in any way.

Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Jul 28, 2024
Copy link

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

@github-actions github-actions bot closed this Aug 27, 2024
auto-merge was automatically disabled August 27, 2024 09:03

Pull request was closed

@Vad1mo Vad1mo reopened this Aug 27, 2024
@github-actions github-actions bot removed the Stale label Aug 28, 2024
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 28, 2024
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants