feat(i18n/gi18n): support fs.FS
#3942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailaz
approved these changes
Nov 22, 2024
gqcn
requested changes
Nov 23, 2024
| if opts.PathFs != nil { | ||
| pathType = pathTypeFS | ||
| } else { | ||
| pathType = opts.checkPathType(opts.Path) |
There was a problem hiding this comment.
能否不定义SetPathFS方法，直接在checkPathType中判断opts.Path路径是否存在于fs.Fs中，如果是得话则用fs.Fs，否则走原来默认逻辑。这样可以降低使用复杂度。
gqcn
changed the title
fs.FS
|
@ynwcel 我将会在近期，尝试在 |
@ynwcel I will try to support |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go test