Update warning ignore tutorial for new annotation-based syntax #6586
Conversation
YuriSizov
added
bug
topic:gdscript
area:manual
If there are some issues that prevent us from creating new screenshots presently, I'd keep them all as is and update them all later, when those issues are addressed. |
|
That's what this PR is, in that case. I've updated the text, but not the screenshots. |
gelvinp
force-pushed
the
warning_system_annotation
branch
from
c63af90 to
8800f4a
Compare
|
Added new screenshots, not an exact replica but ignoring a warning that does work. Also removed the section about file-level ignores. I thought this was true based on reading through the source, but I was not able to make it work in RC 6. |
Resolved conflicts caused by godotengine#6851
gelvinp
force-pushed
the
warning_system_annotation
branch
from
8800f4a to
7aab718
Compare
|
Updated to resolve conflicts introduced earlier today. Is there a reason this has been sitting unmerged for almost two months? |
Nothing wrong on your side, don't worry. Just other priorities for maintainers, and general lack of time to get to everything. |
|
No worries, I was just unsure if there were additional changes I needed to make that I wasn't aware of. I know things have been busy with 4.0 stable. |
|
Sorry this has been sitting here for a bit due to the volume of PRs; we've just merged #8250 which targets the same changes and should supersede this. If there is still anything worth adding, a new followup PR is welcome. Thanks again :) |
mhilbrunner
added
archived
and removed
bug
topic:gdscript
area:manual
I've updated the text of the warning-ignore tutorial to reflect the new annotation based syntax. However I have not updated the screenshots, as the warning system still does not work correctly and if I did take screenshots, they would show incorrect behavior.
I asked in #5121 what I should do about the screenshots but didn't get a response, so I'm opening a PR with just the text right now, and I can force push something if needed.