Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document using nproc instead of hardcoded number of threads #4476

Merged
merged 10 commits into from
Dec 24, 2020
Merged

Document using nproc instead of hardcoded number of threads #4476

merged 10 commits into from
Dec 24, 2020

Conversation

Enhex
Copy link
Contributor

@Enhex Enhex commented Dec 23, 2020

on linux nproc command prints the number of virtual cores available, and putting it inside grave accents will evaluate the command and replace it with its output.

@Enhex
use nproc instead of hardcoded number of threads.
ece2ef5 
on linux nproc command prints the number of virtual cores available, and putting it inside grave accents will evaluate the command and replace it with its output.
Calinou
Calinou requested changes Dec 23, 2020
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the $() syntax rather than the deprecated backtick syntax.

Also, beware as nproc is not available on BSDs by default. Since this page is about compiling for Linux and BSD, I'm not sure if it's a good idea to add it.

development/compiling/compiling_for_linuxbsd.rst Outdated Show resolved Hide resolved
development/compiling/compiling_for_linuxbsd.rst Outdated Show resolved Hide resolved
Enhex and others added 4 commits December 23, 2020 22:20
@Enhex @Calinou
Update development/compiling/compiling_for_linuxbsd.rst
aa55b2f 
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
@Enhex
show how to automatically all cores
8dc4b25 
instead of using nproc directly, because it isn't available on BSD
@Enhex
fix typo
f21444c
@Enhex
CI fix
b2ac4f6
@Enhex Enhex requested a review from Calinou December 24, 2020 06:15
Calinou
Calinou approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou changed the title use nproc instead of hardcoded number of threads. Document using nproc instead of hardcoded number of threads Dec 24, 2020
@Calinou Calinou merged commit 5cfdce4 into godotengine:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enhex @Calinou