[4.3] Revert "Unexpose UtilityFunctions::is_instance_valid()"
#1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 56cd3fd.
dsnopek
added
bug
|
This is still not included in the |
|
@ashtonmeuser We currently do godot-cpp releases at the same time as Godot releases, so it'll end up in 4.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 56cd3fd aka PR #1513.
It fixes issue #1587 (for Godot 4.3 and earlier), which pointed out that there is a use-case that can't be currently be replicated using
ObjectIDandObjectDB.(See PR godotengine/godot#97119 for a way to keep the removal of
UtilityFunctions::is_instance_valid()while still allowing for this use-case, but it will need to be Godot 4.4+)