Grpc backend prototype #583
Conversation
| @@ -39,6 +39,9 @@ var ( | |||
| clientParamTemplate *template.Template | |||
| clientResponseTemplate *template.Template | |||
| clientFacadeTemplate *template.Template | |||
| gRpcDefTemplate *template.Template | |||
| gRpcServerImplTemplate *template.Template | |||
| gRpcClientImplTemplate *template.Template | |||
There was a problem hiding this comment.
var gRpcClientImplTemplate should be gRPCClientImplTemplate
|
this looks great :) I updated the build on master to only use 1.6 I think that might help with the way you've written the templates. |
| TLSCACertificate flags.Filename `long:"tls-ca-certificate" description:"the CA certificate to use for secure connections" env:"TLS_CA_CERTIFICATE"` | ||
| } | ||
|
|
||
| func NewClient() *Client { |
There was a problem hiding this comment.
exported function NewClient should have comment or be unexported
There was a problem hiding this comment.
exported function NewClient should have comment or be unexported
|
are you done with this? |
|
not yet, just moved focus to other emergency on work :S Ivan Porto Carrero notifications@github.com于2016年7月22日周五 上午1:11写道：
|
|
Hi @flier how is your situation at the moment. Thank you very much for your work so far in this PR, would it be a lot of work to finish this of? What would you like to see happening with this PR? :) Thanks again, your time and effort is very well appreciated! |
prototype resolve #582
This change is