Skip to content

Commit

Permalink
Added stubs/map_util.h to list of installed headers
Browse files Browse the repository at this point in the history
This should fix issue protocolbuffers#6186. I also had to remove a couple unnecessary
const keywords in map_util.h because the no_warning_test was showing
errors about those.
  • Loading branch information
acozzette committed Jun 21, 2019
1 parent 1f0d817 commit 4aa7750
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ nobase_include_HEADERS = \
google/protobuf/stubs/hash.h \
google/protobuf/stubs/logging.h \
google/protobuf/stubs/macros.h \
google/protobuf/stubs/map_util.h \
google/protobuf/stubs/mutex.h \
google/protobuf/stubs/once.h \
google/protobuf/stubs/platform_macros.h \
Expand Down
4 changes: 2 additions & 2 deletions src/google/protobuf/stubs/map_util.h
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ bool UpdateReturnCopy(Collection* const collection,
// twice. Unlike UpdateReturnCopy this also does not come with the issue of an
// undefined previous* in case new data was inserted.
template <class Collection>
typename Collection::value_type::second_type* const
typename Collection::value_type::second_type*
InsertOrReturnExisting(Collection* const collection,
const typename Collection::value_type& vt) {
std::pair<typename Collection::iterator, bool> ret = collection->insert(vt);
Expand All @@ -633,7 +633,7 @@ InsertOrReturnExisting(Collection* const collection,

// Same as above, except for explicit key and data.
template <class Collection>
typename Collection::value_type::second_type* const
typename Collection::value_type::second_type*
InsertOrReturnExisting(
Collection* const collection,
const typename Collection::value_type::first_type& key,
Expand Down

0 comments on commit 4aa7750

Please sign in to comment.