Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Automatically assign a PR to its author #1253

Merged
merged 2 commits into from
Jun 21, 2023
Merged

ci: Automatically assign a PR to its author #1253

merged 2 commits into from
Jun 21, 2023

Conversation

rapsealk
Copy link
Contributor

This PR resolves #667, using a well-known GitHub Actions workflow toshimaru/auto-author-assign.

Please refer this to see how it will work.

@rapsealk rapsealk changed the title ci: Automatically assign a PR to the author ci: Automatically assign a PR to its author Jun 21, 2023
@ever0de ever0de requested review from panarch, ever0de and devgony June 21, 2023 12:08
@coveralls
Copy link

coveralls commented Jun 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5335695283

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 98.625%
Totals Coverage Status
Change from base Build 5229042071: -0.04%
Covered Lines: 43479
Relevant Lines: 44085
💛 - Coveralls

@ever0de
Copy link
Member

ever0de commented Jun 21, 2023

Maybe you could consider kentaro-m/auto-assign-action?
It's not a huge difference, but it has additional features like assigning reviewers, etc. and it seems like a reasonable choice for maintenance to use the workflow that has more users.
What do you think?

@rapsealk
Copy link
Contributor Author

@ever0de Thanks for the comment! It seems that kentaro-m/auto-assign-action has more recent commits and more active users. I will fix this PR to use this one.

@rapsealk
Copy link
Contributor Author

@ever0de Update completed. Please refer this to see how it works.

ever0de
ever0de approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good 👍, Now we don't have to specify it manually, which is nice 😃

@panarch panarch added the improvement Improvements for existing features label Jun 21, 2023
panarch
panarch approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks really good! Thanks a lot for the contribution 👍 👍

@panarch panarch merged commit 324787e into gluesql:main Jun 21, 2023
@rapsealk rapsealk deleted the ci/pr-auto-author-assign branch June 21, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devgony devgony devgony approved these changes

@ever0de ever0de ever0de approved these changes

@panarch panarch panarch approved these changes

Assignees

@rapsealk rapsealk

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Assignees automatically when someone creates PR
5 participants
@rapsealk @coveralls @ever0de @panarch @devgony