Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UINT32, UINT64 and UINT128 data types #1019

Merged
merged 67 commits into from
Apr 6, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
0411a1f
feat: add new unsigned integer data type
ChobobDev Nov 26, 2022
45e8159
feat: add new unsinged integer data type
ChobobDev Nov 26, 2022
784cdcc
feat: add new datatype into macro.rs
ChobobDev Nov 26, 2022
f22f06c
feat: implememnt convert for unsigned int
ChobobDev Nov 26, 2022
bbfcede
feat: add unsinged int to primitive
ChobobDev Nov 26, 2022
f4232ad
feat: add unsinged int to key and json rs
ChobobDev Nov 26, 2022
e6dcdc5
fix: remove unreachable data type
ChobobDev Nov 26, 2022
e5f1b9c
style: thx fmt
ChobobDev Nov 26, 2022
9928766
test: improve coverage of macros
ChobobDev Nov 26, 2022
f285763
test: improve coverage of json.rs
ChobobDev Nov 26, 2022
1a296e3
test: improve line coverage of convert.rs
ChobobDev Nov 26, 2022
6a93f2e
style: thx fmt
ChobobDev Nov 26, 2022
7ee58e4
test: remove misleading test case
ChobobDev Nov 26, 2022
2cd2f89
test: improve line coverage
ChobobDev Jan 13, 2023
ef3c5f8
Merge branch 'main' into feature/uint_data_type
ChobobDev Jan 13, 2023
bc2a1ef
style: thx clippy
ChobobDev Jan 13, 2023
29893a7
fix: fix misleading expression
ChobobDev Jan 13, 2023
4de73ee
fix : fix typo
ChobobDev Jan 13, 2023
0ef9781
test : improve line coverage of `expr.rs`
ChobobDev Jan 13, 2023
64e5f39
test: improve coverage of `bigdecimal_ext.rs`
ChobobDev Jan 13, 2023
52ee74e
style: cargo fmt
ChobobDev Jan 13, 2023
5807764
test: improve line coverage of `value/mod.rs`
ChobobDev Jan 13, 2023
33b2c0f
style : cargo fmt
ChobobDev Jan 13, 2023
884a16c
test: improve line coverage of `value/mod.rs`
ChobobDev Jan 13, 2023
e994a0a
style: cargo fmt
ChobobDev Jan 13, 2023
4cf9eff
test: improve line coverage of `f64.rs`
ChobobDev Jan 13, 2023
7b35f26
style: cargo fmt
ChobobDev Jan 13, 2023
67d4cf6
test: improve line coverage of `decimal.rs`
ChobobDev Jan 13, 2023
8d163f3
style: cargo fmt
ChobobDev Jan 13, 2023
589f32d
test: improve line coverage of `key.rs`
ChobobDev Jan 14, 2023
621c502
feat: add the missing data type translation in `translate/data_type.rs`
ChobobDev Jan 14, 2023
d6d7441
feat: Add literals for missing data types
ChobobDev Jan 14, 2023
06efa4a
test: improve line coverage of `primitive.rs`
ChobobDev Jan 14, 2023
c0ecf44
test : improve line coverage
ChobobDev Jan 14, 2023
cf4a4c8
fix : resolve `try_from_literal` error
ChobobDev Jan 14, 2023
288c453
test: improve line coverage of `mod.rs`
ChobobDev Jan 14, 2023
0cb6a7b
test: improve line coverage of `mod.rs`
ChobobDev Jan 14, 2023
d78bc02
test: add missing tests
ChobobDev Jan 14, 2023
60dcdd3
style: cargo fmt
ChobobDev Jan 14, 2023
7387c31
Merge branch 'main' into feature/uint_data_type
ChobobDev Feb 10, 2023
18aa579
merge main into feature branch
ChobobDev Feb 10, 2023
dcd7d59
style: cargo fmt
ChobobDev Feb 10, 2023
5a9db7f
fix: fix merge error
ChobobDev Feb 10, 2023
fd6a036
fix : try merging the main again
ChobobDev Feb 10, 2023
c7cfbbe
Merge branch 'main' into feature/uint_data_type
ChobobDev Feb 10, 2023
eeaff8a
merge main into feature branch
ChobobDev Mar 25, 2023
2c7bcef
fix : fix impossibleCast list for the newly added data types
ChobobDev Mar 25, 2023
953bbc2
fix: handle uuid in u128 format
ChobobDev Mar 25, 2023
8748bbc
fix : allow both uuid and str to be ran
ChobobDev Mar 25, 2023
1de3bbd
fix: tried using and_then
ChobobDev Mar 25, 2023
9731a11
fix: check parse_uuid whether it returns error
ChobobDev Mar 25, 2023
129a5de
fix: remove unnecessary Str to Uuid conversion
ChobobDev Mar 26, 2023
6831d5d
Merge branch 'main' into feature/uint_data_type
ChobobDev Apr 2, 2023
96e19f1
fix: fix wierdly merged lines
ChobobDev Apr 2, 2023
b8c1cb3
test : add test case
ChobobDev Apr 2, 2023
9c62b2c
fix : reset the branch
ChobobDev Apr 4, 2023
f33230b
Merge branch 'main' into feature/uint_data_type
ChobobDev Apr 4, 2023
bdbff0d
style: cargo fmt
ChobobDev Apr 4, 2023
b63e68d
fix: remove unnecessary comment
ChobobDev Apr 6, 2023
dbb5094
test : improve line coverage
ChobobDev Apr 6, 2023
59357a7
style: cargo fmt
ChobobDev Apr 6, 2023
da3be0d
test : fix misleading test case
ChobobDev Apr 6, 2023
b32e786
test: add ommited test case
ChobobDev Apr 6, 2023
d8feb37
test : improve line coverage
ChobobDev Apr 6, 2023
9693a12
test : add ommitted test case
ChobobDev Apr 6, 2023
3bfc068
test : change misleading test case
ChobobDev Apr 6, 2023
6a4252a
test : add omitted test-suites for new data types
ChobobDev Apr 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix wierdly merged lines
  • Loading branch information
ChobobDev committed Apr 2, 2023
commit 96e19f1af81287dcb2f2dc4dc274c761fb3a8639
8 changes: 7 additions & 1 deletion core/src/data/key.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ impl Ord for Key {
(Key::I128(l), Key::I128(r)) => l.cmp(r),
(Key::U8(l), Key::U8(r)) => l.cmp(r),
(Key::U16(l), Key::U16(r)) => l.cmp(r),
(Key::U32(l),Key::U32(r))=> l.cmp(r),
(Key::U64(l),Key::U64(r))=> l.cmp(r),
(Key::U128(l),Key::U128(r))=> l.cmp(r),
(Key::F64(l), Key::F64(r)) => l.total_cmp(&r.0),
(Key::Decimal(l), Key::Decimal(r)) => l.cmp(r),
(Key::Bool(l), Key::Bool(r)) => l.cmp(r),
Expand All @@ -81,6 +84,9 @@ impl Ord for Key {
| (Key::I128(_), _)
| (Key::U8(_), _)
| (Key::U16(_), _)
| (Key::U32(_),_)
| (Key::U64(_),_)
| (Key::U128(_),_)
| (Key::F64(_), _)
| (Key::Decimal(_), _)
| (Key::Bool(_), _)
Expand Down Expand Up @@ -119,7 +125,7 @@ impl PartialOrd for Key {
(Key::Interval(l), Key::Interval(r)) => l.partial_cmp(r),
(Key::Uuid(l), Key::Uuid(r)) => Some(l.cmp(r)),
_ => None,
}
};
Some(self.cmp(other))
}
}
Expand Down
5 changes: 0 additions & 5 deletions core/src/data/value/convert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -697,11 +697,6 @@ mod tests {
use {
super::{ Value, ValueError},
crate::{data::Interval as I, result::Result},
super::{Value, ValueError},
crate::{
data::{value::uuid::parse_uuid, Interval as I},
result::Result,
},
chrono::{self, NaiveDate, NaiveDateTime, NaiveTime},
rust_decimal::Decimal,
std::{
Expand Down