Set "PRIMARY" as a reserved keyword for index names (#960)

Set "PRIMARY" as a reserved keyword for index names. Block use of "PRIMARY" name in create or drop index queries.
gluesql · Oct 20, 2022 · 29e9bd2 · 29e9bd2
1 parent 3557d48
commit 29e9bd2
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/core/src/translate/error.rs b/core/src/translate/error.rs
@@ -122,4 +122,10 @@ pub enum TranslateError {
 
     #[error("unimplemented - compound object is supported: {0}")]
     CompoundObjectNotSupported(String),
+
+    #[error("cannot create index with reserved name: {0}")]
+    ReservedIndexName(String),
+
+    #[error("cannot drop primary index")]
+    CannotDropPrimary,
 }
diff --git a/core/src/translate/mod.rs b/core/src/translate/mod.rs
@@ -114,8 +114,14 @@ pub fn translate(sql_statement: &SqlStatement) -> Result<Statement> {
                 return Err(TranslateError::CompositeIndexNotSupported.into());
             }
 
+            let name = translate_object_name(name)?;
+
+            if name.to_uppercase() == "PRIMARY" {
+                return Err(TranslateError::ReservedIndexName(name).into());
+            };
+
             Ok(Statement::CreateIndex {
-                name: translate_object_name(name)?,
+                name,
                 table_name: translate_object_name(table_name)?,
                 column: translate_order_by_expr(&columns[0])?,
             })
@@ -138,6 +144,10 @@ pub fn translate(sql_statement: &SqlStatement) -> Result<Statement> {
             let table_name = object_name[0].value.to_owned();
             let name = object_name[1].value.to_owned();
 
+            if name.to_uppercase() == "PRIMARY" {
+                return Err(TranslateError::CannotDropPrimary.into());
+            };
+
             Ok(Statement::DropIndex { name, table_name })
         }
         #[cfg(feature = "transaction")]

diff --git a/test-suite/src/dictionary_index.rs b/test-suite/src/dictionary_index.rs
@@ -1,4 +1,7 @@
-use {crate::*, gluesql_core::prelude::Value::*};
+use {
+    crate::*,
+    gluesql_core::{prelude::Value::*, translate::TranslateError},
+};
 
 test_case!(ditionary_index, async move {
     run!("CREATE TABLE Foo (id INT, name TEXT);");
@@ -27,4 +30,18 @@ test_case!(ditionary_index, async move {
             "Foo".to_owned()   "Foo_id_2".to_owned()         "BOTH".to_owned()   "id + 2".to_owned()        false
         ))
     );
+
+    let test_cases = [
+        (
+            "DROP INDEX Bar.PRIMARY",
+            Err(TranslateError::CannotDropPrimary.into()),
+        ),
+        (
+            "CREATE INDEX Primary ON Foo (id)",
+            Err(TranslateError::ReservedIndexName("Primary".to_owned()).into()),
+        ),
+    ];
+    for (sql, expected) in test_cases {
+        test!(sql, expected);
+    }
 });