-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom asset field editor ux redesign #18577
base: main
Are you sure you want to change the base?
Conversation
Quick review after testing this early rework:
|
While discussing drag controls, in fact, let's remove them completely:
|
Moar:
|
I think users will expect all of the native fields to be present already, especially if they are fields related to capacities they enabled. Also, if they are creating multiple custom asset types they may get annoyed if they have to keep enabling all of the native fields. This may be a place where a discovery tutorial could be useful, or just try to have an intuitive UI. I find the sidebar design intuitive as it is (maybe hide the section headers when they are empty), but I don't know how other people will see it. |
|
ok.
I would like to see how it renders |
Ok for the current state. I guess we should always keep "custom fields" section because the button for adding will always be present. Apart this, PR is ok for me, please fix tests, and we will go for merge. |
3a8108a
to
9ca2f86
Compare
Remaining test failure doesn't seem related at all. |
Checklist before requesting a review
Description
Fixes #18406