Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Disallow xarray 0.21.0 in setup.cfg #976

Merged
merged 1 commit into from
Jan 29, 2022
Merged

🩹 Disallow xarray 0.21.0 in setup.cfg #976

merged 1 commit into from
Jan 29, 2022

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jan 29, 2022 •
edited
Loading

Currently our ASV workflow fails since xarray==0.21.0 had a mishap forgetting to add packaging as a dependency.
Happens to the best of us, especially since packaging piggybacks on pytest so you won't see this error in any test environment, and even in our docs something added it, so they pass.

Anyway, to have our benchmarks work and go on with our stuff, let's just disallow this version until everything is sorted out.

If xarray decides to make a post-release, we can simply revert this change. If they rather choose to make a bugfix release it will stay in.

Change summary

  • 🩹 Disallow xarray 0.21.0

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/disallow-xarray-0.21.0

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 29, 2022 •
edited
Loading

Codecov Report

Merging #976 (c915d45) into main (a7f67d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #976   +/-   ##
=====================================
  Coverage   85.6%   85.6%           
=====================================
  Files         90      90           
  Lines       4883    4883           
  Branches     916     916           
=====================================
  Hits        4181    4181           
  Misses       552     552           
  Partials     150     150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f67d4...c915d45. Read the comment docs.

@github-actions
Copy link
Contributor

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.5.1 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [96b42630]       [c915d45d]
     <v0.5.1>                   
       62.7±0.8ms         64.0±2ms     1.02  BenchmarkOptimize.time_optimize(False, False, False)
        81.4±40ms        94.7±30ms    ~1.16  BenchmarkOptimize.time_optimize(False, False, True)
         64.8±2ms         60.0±1ms     0.93  BenchmarkOptimize.time_optimize(False, True, False)
        68.7±20ms         66.5±3ms     0.97  BenchmarkOptimize.time_optimize(False, True, True)
         78.7±2ms         76.3±3ms     0.97  BenchmarkOptimize.time_optimize(True, False, False)
        94.7±30ms        83.2±40ms    ~0.88  BenchmarkOptimize.time_optimize(True, False, True)
         75.6±1ms         77.7±1ms     1.03  BenchmarkOptimize.time_optimize(True, True, False)
        82.5±40ms        92.7±40ms    ~1.12  BenchmarkOptimize.time_optimize(True, True, True)
             203M             205M     1.01  IntegrationTwoDatasets.peakmem_optimize
       2.17±0.05s       1.99±0.05s     0.92  IntegrationTwoDatasets.time_optimize
Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [a7f67d4a]       [c915d45d]
         62.3±2ms         64.0±2ms     1.03  BenchmarkOptimize.time_optimize(False, False, False)
         67.6±3ms        94.7±30ms    ~1.40  BenchmarkOptimize.time_optimize(False, False, True)
         64.5±1ms         60.0±1ms     0.93  BenchmarkOptimize.time_optimize(False, True, False)
        98.3±40ms         66.5±3ms    ~0.68  BenchmarkOptimize.time_optimize(False, True, True)
         73.5±2ms         76.3±3ms     1.04  BenchmarkOptimize.time_optimize(True, False, False)
        84.6±30ms        83.2±40ms     0.98  BenchmarkOptimize.time_optimize(True, False, True)
       74.8±0.8ms         77.7±1ms     1.04  BenchmarkOptimize.time_optimize(True, True, False)
         106±30ms        92.7±40ms    ~0.87  BenchmarkOptimize.time_optimize(True, True, True)
             201M             205M     1.02  IntegrationTwoDatasets.peakmem_optimize
       2.02±0.05s       1.99±0.05s     0.98  IntegrationTwoDatasets.time_optimize

jsnel
jsnel approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s-weigand s-weigand merged commit 70a6d4c into glotaran:main Jan 29, 2022
@s-weigand s-weigand deleted the disallow-xarray-0.21.0 branch January 29, 2022 14:01
@s-weigand s-weigand mentioned this pull request Jan 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnel jsnel jsnel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-weigand @jsnel