Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glasskube describe command #241

Closed
christophenne opened this issue Feb 12, 2024 · 10 comments · Fixed by #294
Closed

glasskube describe command #241

christophenne opened this issue Feb 12, 2024 · 10 comments · Fixed by #294
Assignees
@christophenne
Labels
component: cli enhancement New feature or request help wanted Extra attention is needed
Milestone
v0.0.3

Comments

@christophenne
Copy link
Member

christophenne commented Feb 12, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
We are working on the package detail page on the UI (#172 ), so there should be an equivalent command for the CLI to show all relevant package details. Just like on the UI, this should work for both uninstalled and installed packages, and the status of the package should be shown.

Describe the solution you'd like
glasskube describe [package-name] should print the same package details to the console as we show in the UI.

Additional context
Depends on #172 to develop the client functionality that can be used by both layers.

For implementing this task, reuse DescribePackage from pkg/describe/describe.go, which contains all the logic to fetch all the relevant data which should be displayed.
@christophenne christophenne added enhancement New feature or request needs-triage labels Feb 12, 2024
@christophenne christophenne added this to the v0.0.3 milestone Feb 12, 2024
@bishal7679
Copy link

Hey @christophenne Would like to give it a try!

@christophenne
Copy link
Member Author

Hi @bishal7679,
I think this issue is too dependent on #172 right now, which is still in progress. Also it would have to be speced in more detail. So I suggest you either wait until these tasks are done, or if you'd like, check out some other issues labeled with "help wanted" or "good first issue" - any help is appreciated :) Thanks!

@bishal7679
Copy link

Np @christophenne
Will look into another issues 👍

@christophenne
Copy link
Member Author

@bishal7679 since the #172 is about the be closed soon, you could work on the describe command. Are you still interested?

@christophenne christophenne added the help wanted Extra attention is needed label Feb 14, 2024
@christophenne christophenne mentioned this issue Feb 14, 2024
Closed
@bishal7679
Copy link

@bishal7679 since the #172 is about the be closed soon, you could work on the describe command. Are you still interested?

Yes! would like to give it a try

@christophenne
Copy link
Member Author

@bishal7679 thanks! I provided some additional information in the description above, if you need anything else, don't hesitate to ask here or on discord.

@bishal7679
Copy link

@bishal7679 thanks! I provided some additional information in the description above, if you need anything else, don't hesitate to ask here or on discord.

Yeah! I'm getting my hands dirty with it and will let you know further update
Thank you!

@christophenne
Copy link
Member Author

Hi @bishal7679, I hope you are doing well. I just wanted to check in and ask how you are doing with this issue. Is there anything we can help you with? If so, please don't hesitate to reach out.

@bishal7679
Copy link

@christophenne I really apologize!
I wrapped up with my exams and didn't get to it!
But I will soon start working on it and will come with update

@christophenne
Copy link
Member Author

@bishal7679 no worries! Thanks for letting us know, please have a quick look in Discord so we can synchronize on how we proceed.

christophenne added a commit that referenced this issue Feb 27, 2024
@christophenne
feat(cli): glasskube describe (#241)
2502bcb
@christophenne christophenne mentioned this issue Feb 27, 2024
Merged
2 tasks
christophenne added a commit that referenced this issue Feb 27, 2024
@christophenne
feat(cli): glasskube describe (#241)
44674a4
christophenne added a commit that referenced this issue Feb 27, 2024
@christophenne
feat(cli): glasskube describe (#241)
4658e2a
christophenne added a commit that referenced this issue Feb 27, 2024
@christophenne
feat(cli): glasskube describe (#241)
7003a60
kosmoz pushed a commit that referenced this issue Feb 27, 2024
@christophenne @kosmoz
feat(cli): glasskube describe (#241)
55bebd6
@github-actions github-actions bot mentioned this issue Feb 27, 2024
Merged
@chenrui333 chenrui333 mentioned this issue Mar 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophenne christophenne

Labels
component: cli enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v0.0.3
Development

Successfully merging a pull request may close this issue.

feat(cli): glasskube describe (#241) glasskube/glasskube
2 participants
@christophenne @bishal7679