fix: clean snapshots should only delete .snap files (#62)

gkampitakis · May 20, 2023 · 6a7fc6c · 6a7fc6c
1 parent 6c41cd3
commit 6a7fc6c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/snaps/clean.go b/snaps/clean.go
@@ -104,7 +104,8 @@ func examineFiles(
 
 		for _, content := range dirContents {
 			// this is a sanity check shouldn't have dirs inside the snapshot dirs
-			if content.IsDir() {
+			// and only delete any `.snap` files
+			if content.IsDir() || filepath.Ext(content.Name()) != snapsExt {
 				continue
 			}
 

diff --git a/snaps/clean_test.go b/snaps/clean_test.go
@@ -86,6 +86,10 @@ func setupTempExamineFiles(t *testing.T) (map[string]map[string]int, string, str
 			name: filepath.FromSlash(dir2 + "/obsolete2.snap"),
 			data: []byte{},
 		},
+		{
+			name: filepath.FromSlash(dir2 + "/should_not_delete.txt"),
+			data: []byte{},
+		},
 	}
 
 	for _, file := range files {

diff --git a/snaps/skip.go b/snaps/skip.go
@@ -87,7 +87,6 @@ func isFileSkipped(dir, filename, runOnly string) bool {
 	}
 
 	testFilePath := path.Join(dir, "..", strings.TrimSuffix(filename, snapsExt)+".go")
-	isSkipped := true
 
 	fset := token.NewFileSet()
 	file, err := parser.ParseFile(fset, testFilePath, nil, parser.ParseComments)
@@ -105,9 +104,9 @@ func isFileSkipped(dir, filename, runOnly string) bool {
 		// If the TestFunction is inside the file then it's not skipped
 		matched, _ := regexp.MatchString(runOnly, funcDecl.Name.String())
 		if matched {
-			isSkipped = false
+			return false
 		}
 	}
 
-	return isSkipped
+	return true
 }