[dashboard] Add org resources to the top of the workspace list #20520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: - [ ] only enable on dedicated installs - [ ] add org setting for org-wide suggestions - [ ] possibly adopt `Recommended` badges from figma - [ ] open configurationId instead of cloneUrl if possible
filiptronicek
commented
Jan 14, 2025
| @@ -42,7 +42,7 @@ export const SetupCompleteStep: FC<Props> = ({ onComplete }) => { | |||
| <Subheading>Your teammates can now sign in to Gitpod using single sign-on (SSO).</Subheading> | |||
|
|
|||
| <div className="flex flex-row items-center space-x-2 mt-4"> | |||
| <div className="flex flex-row items-center space-x-1 font-mono text-sm text-gray-500 dark:text-gray-600"> | |||
| <div className="flex flex-row items-center space-x-1 font-mono text-sm text-pk-content-secondary"> | |||
There was a problem hiding this comment.
This is a drive-by. I noticed that in the installation setup, the contrast of this text with the background is too small.
filiptronicek
commented
Jan 14, 2025
| @@ -344,7 +344,7 @@ export class OrganizationServiceAPI implements ServiceImpl<typeof OrganizationSe | |||
| "onboardingSettings can only be set on enterprise installations", | |||
| ); | |||
| } | |||
| if (req.onboardingSettings.internalLink?.length ?? 0 > 255) { | |||
| if ((req.onboardingSettings.internalLink?.length ?? 0) > 255) { | |||
There was a problem hiding this comment.
This is a fix for a regression from #20508. Operator precedence is hard :P
filiptronicek
commented
Jan 14, 2025
| <Header title="Workspaces" subtitle="Manage recent and stopped workspaces." /> | ||
| <Header | ||
| title="Workspaces" | ||
| subtitle="Manage, start and stop your personal development environments in the cloud." |
There was a problem hiding this comment.
Copy comes from this Figma.
|
Looks all very clean and ready to go! I have two smaller comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a couple of quick links to the top of the workspaces page.
👆 this is how the cards look like when there is an
internalLinkconfigured as part of the organization's onboarding settings. If there's none, this card will be shown instead:Related Issue(s)
Fixes CLC-1063
How to test
https://ft-suggest2ff3f7fd93.preview.gitpod-dev.com
/hold