Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show workspace details in usage list view #11640

Closed
Tracked by #9036
laushinka opened this issue Jul 26, 2022 · 4 comments · Fixed by #12135
Closed
Tracked by #9036

Show workspace details in usage list view #11640

laushinka opened this issue Jul 26, 2022 · 4 comments · Fixed by #12135
Assignees
Labels
feature: billing team: webapp Issue belongs to the WebApp team

Comments

@laushinka
Copy link
Contributor

laushinka commented Jul 26, 2022

@jldec updated Aug 9

Workspace details in a dropdown or inline in each row
Let's increase the page size to 50 for now (#12122)

Must haves

**Nice to have (ok skip for now) **

  • Project (link)
  • Stopped date/time (actual)

From Figma

Screenshot 2022-08-09 at 09 58 08

NOTE: Other design changes are discussed in separate issue #11953

@laushinka laushinka added team: webapp Issue belongs to the WebApp team feature: billing labels Jul 26, 2022
@svenefftinge
Copy link
Member

svenefftinge commented Jul 26, 2022

Looks great, some thoughts I had:

  • some of the header titles don't make sense
  • project (instead of 'repository) should be a top-level property
  • status doesn't make so much sense here IMHO
  • session would probably confuse users more than it helps. Maybe we omit it and work with workspace id plus started time to reference an instance?
  • Monthly Usage could be something like Usage in Period. Sounds like an average otherwise. Also, I believe we are going to allow more flexibility with the period selection in the future.
  • Last Active could be just Date without using moment but an absolute time stamp. Makes IMHO more sense when looking into things form the past and sort, filtering them.

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 26, 2022

Some thoughts on the feedback points from bottom to top, while keeping in mind this is still work-in-progress:

Last Active could be just Date without using moment but an absolute time stamp. Makes IMHO more sense when looking into things form the past and sort, filtering them.

Good point! 🤝

Monthly Usage could be something like Usage in Period. Sounds like an average otherwise.

Agree, we've already changed this to Total Usage in the proposed changes in #11526 which will make more sense once we introduce the option to drill down to usage types like workspaces, prebuilds, etc., see early designs in the relevant discussion (internal). Feedback is welcome! ✔️

Also, I believe we are going to allow more flexibility with the period selection in the future.

Yes! See #11526 (comment).

session would probably confuse users more than it helps. Maybe we omit it and work with workspace id plus started time to reference an instance?

This was inspired from a past discussion in #10328 (comment) with the intent to start exposing users to the concept of session which could be useful also on the workspaces list later. However, I agree we could skip that for now and re-introduce later. 🤝

status doesn't make so much sense here IMHO

This is related to whether we surface running workspace or prebuilds in this list, no? So far, the consensus I've seen is to include running workspaces (see. relevant discussion (internal)) but I'm not sure about the current implementation. If we are going to include running workspaces, we'd have to make sure the STOPPED time remains blank or includes an indicator this is still running, etc.

project (instead of 'repository) should be a top-level property

Good point! This was probably left outside while tackling data structure which is different for workspaces and prebuilds, like the workspace ID v. prebuild ID and workspace owner vs. missing prebuild triggerer (see relevant note (internal)).

some of the header titles don't make sense

homer-simpson


Thanks @laushinka for opening this and @svenefftinge for the feedback!

@gtsiolis
Copy link
Contributor

gtsiolis commented Jul 29, 2022

Posting a new iteration of the workspaces details, including font color, weight, and alignment on the table in the scope of #11527. Changes from the last iteration include the following:

  1. Toned down left sidebar elements
  2. Surface workspace or prebuild ID on the visible row details
  3. Included (optional) project column in the details
  4. Experimenting with same color active row and details panel
  5. Split user avatar and moved to end of the row just before the toggle icon to provide better visual balance when the avatar is missing for prebuilds.
  6. Introduced an icon indicator ⚪ + ⬜ for differentiating workspaces and prebuilds without the need to repeat the type with text while also carrying the icon used in the workspaces list for workspaces' status.
Light Theme Dark Theme
usage-light usage-dark

See design specs.

@jldec jldec changed the title Show workspace details Show workspace details in usage list view Aug 8, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 9, 2022

Adding below the updated design specs for the usage list after this morning's discussion and pairing session with @laushinka and @jldec. 🍐

Usage (List)
UsageAllInOne

See design specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: billing team: webapp Issue belongs to the WebApp team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants