Description:

This pull request should not change any functionality, it only simplifies the regex generated by GenerateSemiGenericRegex and GenerateUniqueTokenRegex a bit, in order to make them easier to understand, (and to make gitleaks.toml 4 KB smaller :-)

based on the sidenote in #1467

Changes:

// in identifierSuffix:
- (?:[\s|']|[\s|"]){0,3}
+ [\s'"|]{0,3}

// in secretPrefix
- (?:'|\"|\s|=|\x60){0,5}
+ [`'"\s=]{0,5}

// in secretSuffix
- (?:['|\"|\n|\r|\s|\x60|;]|$)
+ (?:[`'"\s;|]|$)

I am not quite certain whether "|" was intended to be included in the character ranges, or whether the intention was that [a|b] should match only a or b, like [ab].

But since the previous regex for identifierSuffix and secretSuffix match for "|", this patch does not change that.

I removed \r\n from the secretSuffix, since it is already included in \s

I also replaced \x60 with `
As far as I could tell, the backtick does not need to be escaped in a toml file, and it was only slightly inconvenient to escape it in code:

- secretPrefix       = `(?:'|\"|\s|=|\x60){0,5}(`
+ secretPrefix       = "[`" + `'"\s=]{0,5}(`

However, I may have misunderstood the ramifications, and can of course undo that if desired.

I have also written some unit tests covering GenerateSemiGenericRegex and GenerateUniqueTokenRegex, in a separate pull request #1623

Checklist:

• Does your PR pass tests?
• Have you written new tests for your changes?
• Have you lint your code locally prior to submission?