added listing org. users #265
Conversation
|
Hi @stromaler. Thank you for your PR, we really appreciate it. However, we can't merge it unless you add to the PR some tests and documentation to the README. |
|
@AurelioDeRosa OK no probs. I do so soon. |
|
@AurelioDeRosa Sorry for delay... I added documentation and test... hope its ok now. |
|
@AurelioDeRosa I don't understand why that tests failing,,, |
|
Tomorrow I'll have a look at it. I'll give you some feedback. |
| // List members of given organization | ||
| // ------- | ||
| this.orgMembers = function (orgId, cb) { | ||
| _request('GET', '/organizations/' + orgId + '/members', options, cb); |
There was a problem hiding this comment.
In passing the data to _request you use an options variable that is never declared.
|
Hi @stromaler. Are you still interested in this PR? |
|
@AurelioDeRosa Yes, sorry, I will complete it this week. |
|
@stromaler This was just released in v1.2.0 |
|
@clayreimann sorry for that, I totally forgot after I stopped work with this lib. |
|
@stromaler No worries, just thought I'd let you know it landed |
Hello, just small addon....