Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Inaccuracy] /repos/{org}/{repo}/actions/required_workflows should be /repos/{owner}/{repo}/actions/required_workflows #2429

Open
baywet opened this issue Apr 6, 2023 · 0 comments

Comments

@baywet
Copy link

baywet commented Apr 6, 2023

Schema Inaccuracy

It's technically invalid from an OpenAPI perspective to have two different single path parameters at the same level. This is because they can't be differentiated and they might have operations that collide between one another.

Expected

  • /repos/{org}/{repo}/actions/required_workflows should be /repos/{owner}/{repo}/actions/required_workflows
  • /repos/{org}/{repo}/actions/required_workflows/{required_workflow_id_for_repo} should be /repos/{owner}/{repo}/actions/required_workflows/{required_workflow_id_for_repo}
  • /repos/{org}/{repo}/actions/required_workflows/{required_workflow_id_for_repo}/timing should be /repos/{owner}/{repo}/actions/required_workflows/{required_workflow_id_for_repo}/timing

Reproduction Steps

N/A

@nickfloyd nickfloyd self-assigned this Apr 12, 2023
@ahoglund ahoglund added the P3 label Apr 17, 2023
@nickfloyd nickfloyd assigned nickfloyd and unassigned nickfloyd Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants