Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring Pow environment settings (Rails) #1257

Merged
merged 3 commits into from
Jan 7, 2015
Merged

Ignoring Pow environment settings (Rails) #1257

merged 3 commits into from
Jan 7, 2015

Conversation

sidewinder94
Copy link
Contributor

Pow is a Rails server for Mac,
These environments settings are specific to each developer and don't need to be committed

@arcresu
Copy link
Contributor

arcresu commented Nov 12, 2014

Thanks for this. What files exactly will this rule ignore? Is there any documentation or examples in the wild to support this addition? Is the glob necessary?

@sidewinder94
Copy link
Contributor Author

In fact i am not a pow user at all, one of my coworkers checked his pow configuration files in mistakenly.

I do at least know about two files :

  • .powconfig
  • .powenv

As i do not use personally this server, i do not know exactly how it works, only know that these files can be added in the project repository to change project specific configuration (i.e. the gems & ruby installation paths)

Do you think it would be better to ignore these two specific files only ?

@arcresu
Copy link
Contributor

arcresu commented Nov 13, 2014

Yes, it's better to avoid overly general rules if they aren't necessary. I'm reluctant to add these without confirmation that it's sensible in the common case to ignore them. Would you mind doing a little research into the docs or the examples which your colleague checked in to see if these files are user/site-specific (if so then that would be good enough reason to add the rule here), or if there is some other obvious reason they aren't useful to other collaborators?

Couldn't find any references to .powconfig  being used in application directory
@sidewinder94
Copy link
Contributor Author

Hi,

I could find these resources, first the .powenv : http://pow.cx/manual.html#section_2.2 is used to set site specific environment vars.
Then the following gem also adds the .powenv to the gitignore (https://github.com/RailsApps/rails_apps_composer/blob/master/recipes/git.rb#L8)

Since i couldn't find any references to the .powconfig file being used in the application directory (it is normally in ~/.powconfig), i'll assume it was my coworker's mistake and take it out of the PR.

@arcresu
Copy link
Contributor

arcresu commented Jan 7, 2015

Thanks for the clarification, and yes it looks like it's all site-specific content in general, so this seems sensible. 🎉

arcresu added a commit that referenced this pull request Jan 7, 2015
Ignoring Pow environment settings (Rails)
@arcresu arcresu merged commit 19e7748 into github:master Jan 7, 2015
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
Ignoring Pow environment settings (Rails)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants