Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated column in unique key error #1461

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Fix generated column in unique key error #1461

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1b863b0
repoduce error in generate-columns-unique
meiji163 Oct 23, 2024
4960711
Merge branch 'master' into meiji163/generated-col-error
meiji163 Oct 24, 2024
1c88601
Merge branch 'master' into meiji163/generated-col-error
meiji163 Dec 18, 2024
c041017
only check non-virtual columns from unique key
meiji163 Dec 18, 2024
6c2a036
fix FilterBy func
meiji163 Dec 18, 2024
703ae0d
fix builder test
meiji163 Dec 18, 2024
1875fb9
error message typo
meiji163 Dec 18, 2024
2fce741
Merge branch 'master' into meiji163/generated-col-error
meiji163 Dec 18, 2024
720f685
Merge branch 'master' into meiji163/generated-col-error
meiji163 Dec 18, 2024
c0cbfd1
modify ColumnList creation
meiji163 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix FilterBy func
  • Loading branch information
@meiji163
meiji163 committed Dec 18, 2024
commit 6c2a036224ec6a09f396b64d6fe8a4cb7fd8aadf
1 change: 1 addition & 0 deletions go/sql/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ func (this *ColumnList) FilterBy(f func(Column) bool) *ColumnList {
filteredCols = append(filteredCols, column)
}
}
filteredList.columns = filteredCols
return filteredList
meiji163 marked this conversation as resolved.
Show resolved Hide resolved
}

Expand Down
2 changes: 2 additions & 0 deletions localtests/generated-columns/create.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,6 @@ begin
insert into gh_ost_test (id, a, b) values (null, 2,0);
insert into gh_ost_test (id, a, b) values (null, 2,1);
insert into gh_ost_test (id, a, b) values (null, 2,2);
update gh_ost_test set b=b+1 where id < 5;
update gh_ost_test set b=b-1 where id >= 5;
end ;;
Loading