Python: Add tests for functional-like programming #17765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can also serve for a place to add tests for constructs like threading.Thread, mulitprocess.Process, concurrent.futures.ThreadPoolExecutor, and concurrent.futures.ProcessPoolExecutor.
tausbn
requested changes
Oct 15, 2024
| import os | ||
|
|
||
| sys.path.append(os.path.dirname(os.path.dirname((__file__)))) | ||
| from testlib import expects |
| sys.path.append(os.path.dirname(os.path.dirname((__file__)))) | ||
| from testlib import expects | ||
|
|
||
| # These are defined so that we can evaluate the test code. |
There was a problem hiding this comment.
These definitions feel like boilerplate that should be shared among tests more generally (and hence defined elsewhere -- testlib perhaps?), but I may be missing something about the setup.
There was a problem hiding this comment.
It is boilerplate, and actually, some of our tests do an import instead. I should change this.
Co-authored-by: Taus <tausbn@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can also serve for a place to add tests for
constructs like threading.Thread, mulitprocess.Process, concurrent.futures.ThreadPoolExecutor, and concurrent.futures.ProcessPoolExecutor.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).