Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reactions to discussions #93

Merged
merged 22 commits into from
Jun 1, 2021
Merged

Implement reactions to discussions #93

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
26949eb
Include reactionGroups in discussion query
laymonage May 31, 2021
9878da6
Create updateDiscussion mutator function
laymonage May 31, 2021
158b3f5
Create updateDiscussionReaction function
laymonage May 31, 2021
48a4d0a
Add breakpoints using min-device-width
laymonage May 31, 2021
3bb178d
Use dmd to apply mb in ReactButtons
laymonage May 31, 2021
bdc4f0c
Add reactions to top-level discussion
laymonage May 31, 2021
475ff35
Use cursor-not-allowed and custom title if not signed in
laymonage May 31, 2021
89c774a
Include reactions totalCount in discussion query
laymonage May 31, 2021
2bce98c
Update reactionCount in updateDiscussionReaction
laymonage May 31, 2021
8f69de3
Show reactions count
laymonage May 31, 2021
20b9f2f
Do not apply mr-4 to primary react button if no reactions exist
laymonage May 31, 2021
6cb2b23
Add reactionsEnabled prop to Giscus and Widget components
laymonage Jun 1, 2021
4dae464
Get reactionsEnabled from query param in widget page
laymonage Jun 1, 2021
b696cdc
Lift config values with direct effects from Configuration
laymonage Jun 1, 2021
372f163
Take reactionsEnabled value in client script
laymonage Jun 1, 2021
bfdb7e1
Add reactions feature toggle in Configuration
laymonage Jun 1, 2021
a947bf5
Use theme value from directConfig in homepage
laymonage Jun 1, 2021
ef9362d
Unify Configuration styling
laymonage Jun 1, 2021
b3de3dd
Expose SWR's mutate function
laymonage Jun 1, 2021
a12645a
Allow discussion creation through reaction buttons
laymonage Jun 1, 2021
c0e9e3f
Check for discussion creation handler in CommentBox
laymonage Jun 1, 2021
5b1c21a
Update README.md
laymonage Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use dmd to apply mb in ReactButtons
  • Loading branch information
@laymonage
laymonage committed May 31, 2021
commit 3bb178d4c4bca7a2688c8e8c83786608adf82db1
4 changes: 2 additions & 2 deletions components/ReactButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default function ReactButtons({
<button
className={`px-3 py-[3px] Link--secondary${
variant !== 'popoverOnly'
? ' mb-4 mr-4 border rounded-md color-bg-tertiary color-border-primary'
? ' mb-1 dmd:mb-4 mr-4 border rounded-md color-bg-tertiary color-border-primary'
: ''
}`}
onClick={togglePopover}
Expand Down Expand Up @@ -105,7 +105,7 @@ export default function ReactButtons({
count > 0 ? (
<button
key={value}
className={`px-2 mb-1 md:mb-4 mr-2 border leading-[26px] color-border-primary rounded-md${
className={`px-2 mb-1 dmd:mb-4 mr-2 border leading-[26px] color-border-primary rounded-md${
viewerHasReacted ? ' color-bg-info' : ''
}`}
disabled={!token}
Expand Down