Improve i18n for branding

giscus · Oct 22, 2021 · 2f9f849 · 2f9f849 · vercel · Oct 22, 2021
1 parent 4b99e45
commit 2f9f849
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 14 deletions.
diff --git a/components/Giscus.tsx b/components/Giscus.tsx
@@ -1,6 +1,6 @@
 import { useContext, useEffect } from 'react';
 import { AuthContext, ConfigContext } from '../lib/context';
-import { useGiscusTranslation } from '../lib/i18n';
+import { Trans, useGiscusTranslation } from '../lib/i18n';
 import { emitData } from '../lib/messages';
 import { IMetadataMessage } from '../lib/types/giscus';
 import { useFrontBackDiscussion } from '../services/giscus/discussions';
@@ -115,16 +115,19 @@ export default function Giscus({ onDiscussionCreateRequest, onError }: IGiscusPr
           ) : null}
           {shouldShowBranding ? (
             <em className="text-sm color-text-secondary">
-              {' '}
-              {t('poweredBy')}{' '}
-              <a
-                href="https://giscus.app"
-                target="_blank"
-                rel="noreferrer noopener nofollow"
-                className="Link--secondary"
-              >
-                giscus
-              </a>
+              <Trans
+                i18nKey="common:poweredBy"
+                components={{
+                  a: (
+                    <a
+                      href="https://giscus.app"
+                      target="_blank"
+                      rel="noreferrer noopener nofollow"
+                      className="Link--secondary"
+                    />
+                  ),
+                }}
+              />
             </em>
           ) : null}
         </div>

diff --git a/locales/en/common.json b/locales/en/common.json
@@ -31,7 +31,7 @@
   "loading": "Loading",
   "loadingComments": "Loading comments…",
   "loadingPreview": "Loading preview…",
-  "poweredBy": "– powered by",
+  "poweredBy": "– powered by <a>giscus</a>",
   "showPreviousReplies": {
     "0": "Show {{count}} previous replies",
     "one": "Show {{count}} previous reply",

diff --git a/locales/pl/common.json b/locales/pl/common.json
@@ -41,7 +41,7 @@
   "loading": "Wczytywanie",
   "loadingComments": "Wczytywanie komentarzy…",
   "loadingPreview": "Wczytywanie podglądu…",
-  "poweredBy": "– zasilane przez",
+  "poweredBy": "– zasilane przez <a>giscus</a>",
   "showPreviousReplies": {
     "0": "Pokaż {{count}} poprzednich odpowiedzi",
     "one": "Pokaż poprzednią odpowiedź",

diff --git a/locales/ro/common.json b/locales/ro/common.json
@@ -36,7 +36,7 @@
   "loading": "Încărcare",
   "loadingComments": "Încărcare comentarii…",
   "loadingPreview": "Încărcare previzualizare…",
-  "poweredBy": "– oferit de",
+  "poweredBy": "– oferit de <a>giscus</a>",
   "showPreviousReplies": {
     "0": "Arată {{count}} răspunsuri anterioare",
     "one": "Arată {{count}} răspuns anterior",