Link to the views module as static library.

gischen · Jul 9, 2013 · 7dae2c4 · 7dae2c4
1 parent 9e3772f
commit 7dae2c4
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/atom.gyp b/atom.gyp
@@ -312,6 +312,17 @@
       'export_dependent_settings': [
         'vendor/brightray/brightray.gyp:brightray',
       ],
+      'conditions': [
+        ['OS=="win"', {
+          'link_settings': {
+            'libraries': [
+              '-limm32.lib',
+              '-loleacc.lib',
+              '<(atom_source_root)/<(libchromiumcontent_library_dir)/views_chromiumcontent.lib',
+            ],
+          },
+        }],
+      ],
     },
     {
       'target_name': 'generated_sources',

diff --git a/common.gypi b/common.gypi
@@ -66,6 +66,24 @@
       4800,  # (v8.h) forcing value to bool 'true' or 'false'
       4819,  # The file contains a character that cannot be represented in the current code page
     ],
+    'msvs_settings': {
+      'VCLinkerTool': {
+        'AdditionalOptions': [
+          # ATL 8.0 included in WDK 7.1 makes the linker to generate following
+          # warnings:
+          #   - warning LNK4254: section 'ATL' (50000040) merged into
+          #     '.rdata' (40000040) with different attributes
+          #   - warning LNK4078: multiple 'ATL' sections found with
+          #     different attributes
+          '/ignore:4254',
+          '/ignore:4078',
+          # views_chromiumcontent.lib generates this warning because it's
+          # symobls are defined as dllexport but used as static library:
+          #   - warning LNK4217: locally defined symbol imported in function
+          '/ignore:4217',
+        ],
+      },
+    },
   },
   'conditions': [
     # Settings to compile with clang under OS X.

diff --git a/vendor/brightray b/vendor/brightray