Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add json ASCII string render #1358

Merged
merged 13 commits into from
Jul 3, 2018
Merged

add json ASCII string render #1358

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f71e543
add render for ascii
duguying May 16, 2018
98acb01
tests
duguying May 16, 2018
7c8d633
add test for AsciiJSON in context
duguying May 16, 2018
e8f5cc0
Merge branch 'master' into master
duguying Jun 3, 2018
5ac9a80
Merge branch 'master' into master
duguying Jun 30, 2018
f1787f6
Merge branch 'master' into master
duguying Jul 1, 2018
64d474b
change 204 to http.StatusNoContent
duguying Jul 2, 2018
551810c
Merge branch 'master' into master
duguying Jul 2, 2018
fe1abc5
use buffer instead of concatenate
duguying Jul 2, 2018
f299ac2
Merge branch 'master' of https://github.com/duguying/gin
duguying Jul 2, 2018
5748abf
add some comment in readme
duguying Jul 2, 2018
9effe91
fix ident
duguying Jul 2, 2018
33eb8b4
Merge branch 'master' into master
appleboy Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change 204 to http.StatusNoContent
  • Loading branch information
@duguying
duguying committed Jul 2, 2018
commit 64d474b2a207e01c425ef7d2dd9dc78267d2844f
4 changes: 2 additions & 2 deletions context_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,9 +690,9 @@ func TestContextRenderNoContentAsciiJSON(t *testing.T) {
w := httptest.NewRecorder()
c, _ := CreateTestContext(w)

c.AsciiJSON(204, []string{"lang", "Go语言"})
c.AsciiJSON(http.StatusNoContent, []string{"lang", "Go语言"})

assert.Equal(t, 204, w.Code)
assert.Equal(t, http.StatusNoContent, w.Code)
assert.Empty(t, w.Body.String())
assert.Equal(t, "application/json", w.HeaderMap.Get("Content-Type"))
}
Expand Down